Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit use of numpy 2.0 to imod > 0.17.1 #904

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Nov 11, 2024

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

I forgot to post the output of show_diff.py yesterday. So I re-ran it today, but today the output shows some noise.
The hatchling things seem concerning, as that is an upstream dependency, so I wouldn't know how the imod patches would affect their dependency tree.

Let me know what I can do to make the output of show_diff.py look normal again / avoid affecting hatchling's dependency tree.

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
noarch
noarch::imod-0.10.0-py_0.tar.bz2
noarch::imod-0.10.1-py_0.tar.bz2
noarch::imod-0.11.2-pyhd8ed1ab_0.tar.bz2
noarch::imod-0.11.3-pyhd8ed1ab_0.tar.bz2
noarch::imod-0.11.4-pyhd8ed1ab_0.tar.bz2
noarch::imod-0.11.5-pyhd8ed1ab_0.conda
noarch::imod-0.11.6-pyhd8ed1ab_0.conda
noarch::imod-0.12.0-pyhd8ed1ab_0.conda
noarch::imod-0.13.0-pyhd8ed1ab_0.conda
noarch::imod-0.13.1-pyhd8ed1ab_0.conda
noarch::imod-0.13.2-pyhd8ed1ab_0.conda
noarch::imod-0.14.0-pyhd8ed1ab_0.conda
noarch::imod-0.14.1-pyhd8ed1ab_0.conda
noarch::imod-0.15.0-pyhd8ed1ab_0.conda
noarch::imod-0.15.1-pyhd8ed1ab_0.conda
noarch::imod-0.15.2-pyhd8ed1ab_0.conda
noarch::imod-0.15.3-pyhd8ed1ab_0.conda
noarch::imod-0.16.0-pyhd8ed1ab_0.conda
noarch::imod-0.17.0-pyhd8ed1ab_0.conda
noarch::imod-0.17.1-pyhd8ed1ab_0.conda
noarch::imod-0.6.1-py_0.tar.bz2
noarch::imod-0.7.0-py_0.tar.bz2
noarch::imod-0.7.1-py_0.tar.bz2
noarch::imod-0.8.0-py_0.tar.bz2
noarch::imod-0.9.0-py_0.tar.bz2
noarch::imod-0.9.0-py_1.tar.bz2
-    "numpy",
+    "numpy <2.0",
noarch::hatchling-1.18.0-pyhd8ed1ab_0.conda
noarch::hatchling-1.19.0-pyhd8ed1ab_0.conda
noarch::hatchling-1.19.1-pyhd8ed1ab_0.conda
noarch::hatchling-1.20.0-pyhd8ed1ab_0.conda
noarch::hatchling-1.21.0-pyhd8ed1ab_0.conda
noarch::hatchling-1.21.1-pyhd8ed1ab_0.conda
noarch::hatchling-1.22.1-pyhd8ed1ab_0.conda
noarch::hatchling-1.22.2-pyhd8ed1ab_0.conda
noarch::hatchling-1.22.3-pyhd8ed1ab_0.conda
noarch::hatchling-1.22.4-pyhd8ed1ab_0.conda
noarch::hatchling-1.22.5-pyhd8ed1ab_0.conda
noarch::hatchling-1.23.0-pyhd8ed1ab_0.conda
noarch::hatchling-1.24.0-pyhd8ed1ab_0.conda
noarch::hatchling-1.24.1-pyhd8ed1ab_0.conda
noarch::hatchling-1.24.2-pyhd8ed1ab_0.conda
noarch::hatchling-1.25.0-pyhd8ed1ab_0.conda
-    "python >=3.8",
+    "python >=3.7",
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64

@JoerivanEngelen JoerivanEngelen requested a review from a team as a code owner November 11, 2024 13:04
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xhochy xhochy merged commit d5be33e into conda-forge:main Nov 22, 2024
3 checks passed
@JoerivanEngelen JoerivanEngelen deleted the fix-imod-0.17.1 branch November 22, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants