Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __cuda dependency to lightgbm #903

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

cbourjau
Copy link
Contributor

@cbourjau cbourjau commented Nov 8, 2024

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

Further context

#789 Added __cuda as a dependency for lightgbm packages depending on cudatoolkit. However, not all cuda builds have that dependency and were thus missed.

Output of show_diff.py:

================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
linux-ppc64le
linux-ppc64le::lightgbm-4.4.0-cuda_py3.10h75e58fc_2.conda
linux-ppc64le::lightgbm-4.4.0-cuda_py3.11h9f78bff_2.conda
linux-ppc64le::lightgbm-4.4.0-cuda_py3.12h3c335b5_2.conda
linux-ppc64le::lightgbm-4.4.0-cuda_py3.8hf861fb2_2.conda
linux-ppc64le::lightgbm-4.4.0-cuda_py3.9h14537e7_2.conda
+    "__cuda",
================================================================================
================================================================================
linux-aarch64
linux-aarch64::lightgbm-4.4.0-cuda_py3.10h9048c5e_2.conda
linux-aarch64::lightgbm-4.4.0-cuda_py3.11h80a3fbe_2.conda
linux-aarch64::lightgbm-4.4.0-cuda_py3.12h85ffe43_2.conda
linux-aarch64::lightgbm-4.4.0-cuda_py3.8h7428acc_2.conda
linux-aarch64::lightgbm-4.4.0-cuda_py3.9h7b0233e_2.conda
+    "__cuda",
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64
linux-64::lightgbm-4.4.0-cuda_py3.10hdc26961_2.conda
linux-64::lightgbm-4.4.0-cuda_py3.11h78b1082_2.conda
linux-64::lightgbm-4.4.0-cuda_py3.12h374d3f4_2.conda
linux-64::lightgbm-4.4.0-cuda_py3.8hd013c3a_2.conda
linux-64::lightgbm-4.4.0-cuda_py3.9h8ad4a74_2.conda
+    "__cuda",

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@cbourjau cbourjau marked this pull request as ready for review November 8, 2024 16:48
@cbourjau cbourjau requested a review from a team as a code owner November 8, 2024 16:48
name: lightgbm
version: 4.4.0
build: cuda*
not_has_depends: cudatoolkit*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge this with the above one and simply omit the (not_)has_depends?

@cbourjau
Copy link
Contributor Author

cbourjau commented Nov 8, 2024

After merging the two yaml sections, show_diffs.py yields the same output as before.

@cbourjau cbourjau requested a review from xhochy November 11, 2024 15:51
@xhochy xhochy merged commit 034d4e8 into conda-forge:main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants