FIX: Replace minimum required Python for hatchling v1.18.0+ #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Also tagging @conda-forge/hatchling to give notice. |
https://github.com/conda-forge/hatchling-feedstock has broken metadata for the minimum Python version required from v1.18.0 onwards (currently v1.25.0). The last version of hatchling that was compatible with Python 3.7 was v1.17.1 as after that https://github.com/pypa/hatch/ PR 1386 introduced Python 3.8+ syntax that made its way into hatchling v1.23.0 onward, though hatchling v1.18.0 was the first version to require Python 3.8+ (c.f. https://github.com/pypa/hatch/releases/tag/hatchling-v1.18.0). This is getting patched for hatchling v1.25.0 (rebuild) and future versions in https://github.com/conda-forge/hatchling-feedstock/ PR 59, so only apply this python replacement patch for releases created prior to now (1731056098000 which in human readable metadata is on 2024-11-08.)
matthewfeickert
force-pushed
the
fix/update-hatchling-min-python
branch
from
9b0562f
to
908b89a
Compare
|
Gentle ping to @conda-forge/core for review. |
4 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/conda-forge/hatchling-feedstock has broken metadata for the minimum Python version required from
v1.18.0onwards (currentlyv1.25.0). The last version ofhatchlingthat was compatible with Python 3.7 wasv1.17.1as after that pypa/hatch#1386 introduced Python 3.8+ syntax that made its way into hatchlingv1.23.0onward, thoughhatchlingv1.18.0was the first version to require Python 3.8+ (c.f. https://github.com/pypa/hatch/releases/tag/hatchling-v1.18.0).c.f. conda-forge/pyhf-feedstock#28 (comment)
This is getting patched for
hatchlingv1.25.0(rebuild) and future versions in conda-forge/hatchling-feedstock#59, so only apply thispythonreplacement patch for releases created prior to now (1731056098000which in human readable metadata is on 2024-11-08.)Checklist
generate_patch_json.pyif absolutely necessary.pre-commit run -aand ensured all files pass the linting checks.version_inis split across multiple lines to passyamllintpython show_diff.pyand posted the output as part of the PR.I use
to ensure that this only affects packages built in the past of today (2024-11-08).