Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda-build & conda 4.11.0 incompatibility #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chenghlee
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@chenghlee chenghlee requested a review from a team as a code owner November 23, 2021 19:14
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Comment on lines +1249 to +1252
if "constrains" in record:
record["constrains"].append("conda !=4.11.0")
else:
record["constrains"] = ["conda !=4.11.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not what you'd want, c.f. conda-forge/conda-feedstock#108 (comment)
(but I'm also not sure what the actual behavior will be).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbargull had to reread the 4.4.0 release log a few times...so since conda-build actually depends on conda this isn't a constrains (which is optional) instead we want to inject this requirement as a depends?

Suggested change
if "constrains" in record:
record["constrains"].append("conda !=4.11.0")
else:
record["constrains"] = ["conda !=4.11.0"]
for i, d in enumerate(record["depends"]):
if dep in d:
record["depends"][i] += ",<4.11.0"
break
else:
record["depends"].append("conda <4.11.0")

@jakirkham
Copy link
Member

Related to issue ( conda/conda-build#4333 )

@jakirkham
Copy link
Member

cc @conda-forge/core

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 9, 2023

Sorry for letting this slip, but is this still relevant 1.5 years later?

@beckermr
Copy link
Member

beckermr commented Mar 9, 2023

same response as in the other thread.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 9, 2023

Ok. I was trying to see how I could help move things forward, either as clear up, review, or maybe just updating the suggested patches to make them current. The easiest would have been to close but it seems like it makes more sense to move them forward.

I didn't want to forget about "old PRs".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants