-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conda-build & conda 4.11.0 incompatibility #189
base: main
Are you sure you want to change the base?
Fix conda-build & conda 4.11.0 incompatibility #189
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
if "constrains" in record: | ||
record["constrains"].append("conda !=4.11.0") | ||
else: | ||
record["constrains"] = ["conda !=4.11.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not what you'd want, c.f. conda-forge/conda-feedstock#108 (comment)
(but I'm also not sure what the actual behavior will be).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbargull had to reread the 4.4.0 release log a few times...so since conda-build
actually depends on conda
this isn't a constrains
(which is optional) instead we want to inject this requirement as a depends
?
if "constrains" in record: | |
record["constrains"].append("conda !=4.11.0") | |
else: | |
record["constrains"] = ["conda !=4.11.0"] | |
for i, d in enumerate(record["depends"]): | |
if dep in d: | |
record["depends"][i] += ",<4.11.0" | |
break | |
else: | |
record["depends"].append("conda <4.11.0") |
Related to issue ( conda/conda-build#4333 ) |
cc @conda-forge/core |
Sorry for letting this slip, but is this still relevant 1.5 years later? |
same response as in the other thread. |
Ok. I was trying to see how I could help move things forward, either as clear up, review, or maybe just updating the suggested patches to make them current. The easiest would have been to close but it seems like it makes more sense to move them forward. I didn't want to forget about "old PRs". |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)