Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pin for s2geography #6753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

Update pin for s2geography #6753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions recipe/migrations/s2geography02.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
__migrator:
build_number: 1
commit_message: Rebuild for s2geography 0.2
kind: version
migration_number: 1
migrator_ts: 1732800552.1833339
s2geography:
- '0.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbovy should we keep this as 0.2.0? (I don't know to what extent we already want to guarantee that 0.2.x bug fix releases are ABI stable)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion on this, as it is likely that either you or I will take care of the few next s2geography releases and therefore have the ability to carefully choose the version numbers. That said, it might be indeed safer to keep 0.2.0 here (and change the pin pattern to x.x.x during the early development stage).