Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for s2geography #6753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for s2geography. The current pinned version is 0.1.2, the latest available version is 0.2 and the max pin pattern is x.x. This migration will impact 2 feedstocks.

Checklist:

  • The new version is a stable supported pin.
  • I checked that the ABI changed from 0.1.2 to 0.2.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping s2geography

This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12069345298 - please use this URL for debugging.

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner November 28, 2024 13:29
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/s2geography and so here I am doing that.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

migration_number: 1
migrator_ts: 1732800552.1833339
s2geography:
- '0.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbovy should we keep this as 0.2.0? (I don't know to what extent we already want to guarantee that 0.2.x bug fix releases are ABI stable)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion on this, as it is likely that either you or I will take care of the few next s2geography releases and therefore have the ability to carefully choose the version numbers. That said, it might be indeed safer to keep 0.2.0 here (and change the pin pattern to x.x.x during the early development stage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants