-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sundials<= 6.5
in cantera 3.0
#33
Comments
Thanks for providing the example! I looked at their recipe and I just see that @conda-forge/core Sorry to ping you all, not sure who else to ask. Is there a policy for supporting multiple versions of compiled dependencies (sundials in this case)? I assume we'll have to recompile/relink against the other versions of sundials that we want to support, is that the case? Thanks! |
If it's necessary during a transition, then that's OK. Just not forever -- eventually, consuming packages are expected to move to the newest supported version.
You can build cantera for both versions of sundials by removing the
in |
This is the output of
|
Thanks for the reply @h-vetinari!
This is being asked for here to support a second dependency which hasn't yet been built for SUNDIALS 6.6 (specifically scikits.odes). I suspect our answer is to not add this support right now, since we are only using this dependency for a single example 🤔
Thanks for the example! I don't see how they have configured to build for multiple SUNDIALS versions 🤔 It doesn't appear in their recipe nor in any of the other configuration or templates that I can see. Odd. |
We've decided that this is not something we want to pursue at this time, so I'm going to close this issue. Thanks for opening it @Naikless! |
Comment:
As discussed here, being able to use older versions of sundials can be useful to increase compatibility with other packages, such as
scikits.odes
.There are feedstocks that support more than one version of sundials, e.g. pycvodes which provides versions for both sundials 6.4 and 6.6.
Currently, Cantera 3.0 as provided by
conda-forge
is pinned tosundials 6.6.*
Can/Should this be relaxed?
The text was updated successfully, but these errors were encountered: