Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid control placeholders shouldn't show during resize #6719

Open
ruggi opened this issue Dec 10, 2024 · 0 comments
Open

grid control placeholders shouldn't show during resize #6719

ruggi opened this issue Dec 10, 2024 · 0 comments
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Dec 10, 2024

No description provided.

@ruggi ruggi self-assigned this Dec 10, 2024
@ruggi ruggi mentioned this issue Dec 10, 2024
Merged
ruggi added a commit that referenced this issue Dec 11, 2024
@ruggi
Split controls for grid rulers and placeholders, don't show placehold…
0a6ad3f 
…ers during item resize (#6720)

**Problem:**

Grid control placeholders should not show while resizing a grid item.

**Fix:**

1. Split the grid controls into two components - one for the
placeholders and one for the ruler/markers.
2. Do not show the placeholders while resizing a grid item (via its
edges)
3. Do some prep work to only show row/col placeholder lines during
marker resize (an incremental PR will take care of that)

| Before | After |
|-----------|--------------|
| ![Kapture 2024-12-11 at 12 22
44](https://github.com/user-attachments/assets/bca7def9-91fc-4095-9cff-9058b77ee609)
| ![Kapture 2024-12-11 at 12 22
02](https://github.com/user-attachments/assets/255ceb5f-6a5e-4085-82b3-5e057ffb4c3e)
|

Fixes #[6719](#6719)
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Split controls for grid rulers and placeholders, don't show placehold…
9bfeaf4 
…ers during item resize (#6720)

**Problem:**

Grid control placeholders should not show while resizing a grid item.

**Fix:**

1. Split the grid controls into two components - one for the
placeholders and one for the ruler/markers.
2. Do not show the placeholders while resizing a grid item (via its
edges)
3. Do some prep work to only show row/col placeholder lines during
marker resize (an incremental PR will take care of that)

| Before | After |
|-----------|--------------|
| ![Kapture 2024-12-11 at 12 22
44](https://github.com/user-attachments/assets/bca7def9-91fc-4095-9cff-9058b77ee609)
| ![Kapture 2024-12-11 at 12 22
02](https://github.com/user-attachments/assets/255ceb5f-6a5e-4085-82b3-5e057ffb4c3e)
|

Fixes #[6719](#6719)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruggi