Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid item ruler markers #6656

Closed
ruggi opened this issue Nov 19, 2024 · 0 comments · Fixed by #6654
Closed

Grid item ruler markers #6656

ruggi opened this issue Nov 19, 2024 · 0 comments · Fixed by #6654
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Nov 19, 2024

No description provided.

@ruggi ruggi self-assigned this Nov 19, 2024
@ruggi ruggi mentioned this issue Nov 19, 2024
2 tasks
@ruggi ruggi closed this as completed in dca813f Nov 20, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
**Problem:**

Selected grid items should show ruler markers on the borders of the grid
to indicate their placement properties.

**Fix:**

Add the ruler markers to the grid controls for items.

**Notes:**
- markers currently target the cell bounds, it should change to the
middle of the space between cells when we have offset indicator lines
(future PR)



https://github.com/user-attachments/assets/b0dd3450-70fa-47cc-b627-e9f792f13ad8



**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode

Fixes #6656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant