Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep shorthand values when changing grid item location #6625

Closed
ruggi opened this issue Nov 8, 2024 · 0 comments · Fixed by #6626
Closed

Keep shorthand values when changing grid item location #6625

ruggi opened this issue Nov 8, 2024 · 0 comments · Fixed by #6626
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Nov 8, 2024

No description provided.

@ruggi ruggi self-assigned this Nov 8, 2024
ruggi added a commit that referenced this issue Nov 8, 2024
**Problem:**

Changing a grid item location that spans multiple cells via a shorthand
(e.g. `gridColumn: '3 / 5'`) regressed and now the interaction causes
the element to shrink to 1-sized dimensions.

**Fix:**

When checking whether to keep the end pins, check whether they come from
a shorthand prop too.

Also, fix naming of variables when calculating the cell bounds so width
is related to cols and height is related to rows.

Fixes #6625
liady pushed a commit that referenced this issue Dec 13, 2024
**Problem:**

Changing a grid item location that spans multiple cells via a shorthand
(e.g. `gridColumn: '3 / 5'`) regressed and now the interaction causes
the element to shrink to 1-sized dimensions.

**Fix:**

When checking whether to keep the end pins, check whether they come from
a shorthand prop too.

Also, fix naming of variables when calculating the cell bounds so width
is related to cols and height is related to rows.

Fixes #6625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant