Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grid element placement props #6601

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Oct 30, 2024

Problem:

There should be a cross button to the side of the Grid Placement inspector subsection to clear those props when set.

Fix:

Add that button, shown unless all values are defaults.

Kapture 2024-10-30 at 15 13 27

Fixes #6600

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Try me

Copy link

relativeci bot commented Oct 30, 2024

#14967 Bundle Size — 58.03MiB (~+0.01%).

e0c2aec(current) vs d1d46c1 master#14966(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14967
     Baseline
#14966
Regression  Initial JS 41.01MiB(~+0.01%) 41.01MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.06% 17.95%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4163 4163
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.31% 27.31%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14967
     Baseline
#14966
Regression  JS 58.02MiB (~+0.01%) 58.02MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch feat/delete-grid-placement-propsProject dashboard


Generated by RelativeCIDocumentationReport issue

@ruggi ruggi merged commit 6ea2882 into master Oct 30, 2024
16 checks passed
@ruggi ruggi deleted the feat/delete-grid-placement-props branch October 30, 2024 14:29
liady pushed a commit that referenced this pull request Dec 13, 2024
**Problem:**

There should be a cross button to the side of the Grid Placement
inspector subsection to clear those props when set.

**Fix:**

Add that button, shown unless all values are defaults.

![Kapture 2024-10-30 at 15 13
27](https://github.com/user-attachments/assets/0402ce1d-dc34-4cb0-9e7b-561d3fc18539)


Fixes #6600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear grid placement props in the inspector
3 participants