Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra acceptable values for grid align/justify content #6584

Closed
ruggi opened this issue Oct 24, 2024 · 0 comments · Fixed by #6585
Closed

Extra acceptable values for grid align/justify content #6584

ruggi opened this issue Oct 24, 2024 · 0 comments · Fixed by #6585
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Oct 24, 2024

No description provided.

@ruggi ruggi self-assigned this Oct 24, 2024
@ruggi ruggi mentioned this issue Oct 24, 2024
Merged
@ruggi ruggi closed this as completed in 2bd05c0 Oct 25, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Grid advanced modal: visible allowed values outside of shown options …
e1335e6 
…for justify/align dropdown (#6585)

**Problem:**

Acceptable values for the dropdowns in the grid advanced modal for
justify/align content should still be visible in the dropdown when set,
even if we don't show them in the full dropdown itself by default.

**Fix:**

1. Add the missing acceptable values to the type enums in `flex.ts`
2. Restrict which values we show in the dropdown to the ones we had so
far (we can tweak this as we go)
3. Add the ability to show an extra dropdown row at the top of the list
if its value is allowed for that dropdown and it's not found in the
available options



https://github.com/user-attachments/assets/9c22d25e-6ac1-4569-945d-e85d22e5fdb2



Fixes #6584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ruggi