Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stretch for filling grid cells #6423

Closed
ruggi opened this issue Sep 27, 2024 · 0 comments · Fixed by #6424
Closed

Use stretch for filling grid cells #6423

ruggi opened this issue Sep 27, 2024 · 0 comments · Fixed by #6424
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Sep 27, 2024

No description provided.

@ruggi ruggi self-assigned this Sep 27, 2024
ruggi added a commit that referenced this issue Sep 30, 2024
**Problem:**

The inspector should show `Stretch` instead of `Fill` for grid children,
and set `alignSelf`/`justifySelf` in those cases.

**Fix:**

1. Set `alignSelf`/`justifySelf` to `stretch` if `Stretch` is selected
in the inspector dropdown for grid children
2. Show `Stretch` instead of `Fill` for label for grid children (note: I
opted for just changing the label here instead of having a different
strategy altogether, since in my mind it's still fulfilling the goal of
"filling" the parent – but lmk if this is the wrong take)

Fixes #6423
liady pushed a commit that referenced this issue Dec 13, 2024
**Problem:**

The inspector should show `Stretch` instead of `Fill` for grid children,
and set `alignSelf`/`justifySelf` in those cases.

**Fix:**

1. Set `alignSelf`/`justifySelf` to `stretch` if `Stretch` is selected
in the inspector dropdown for grid children
2. Show `Stretch` instead of `Fill` for label for grid children (note: I
opted for just changing the label here instead of having a different
strategy altogether, since in my mind it's still fulfilling the goal of
"filling" the parent – but lmk if this is the wrong take)

Fixes #6423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant