Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid basic minmax support #6392

Closed
ruggi opened this issue Sep 19, 2024 · 0 comments · Fixed by #6393
Closed

Grid basic minmax support #6392

ruggi opened this issue Sep 19, 2024 · 0 comments · Fixed by #6393
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Sep 19, 2024

No description provided.

@ruggi ruggi self-assigned this Sep 19, 2024
@ruggi ruggi mentioned this issue Sep 19, 2024
Merged
@ruggi ruggi closed this as completed in 0a6db9d Sep 20, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Grids: basic minmax support (#6393)
0724c8e 
**Problem:**

We currently don't support `minmax` in grid templates.

**Fix:**

This PR adds initial support for `minmax` throughout the grid flows.

**Commit Details:**

Parse `minmax` functions and keep them in the grid template data, so
they correctly are kept while operating on the grid template itself.

**⚠️ Note:** there's ongoing work to support editing grid template
expressions as strings, so I did not include proper editing in this one
(there was a simple version [`3919cf7`
(#6393)](3919cf7)
but I decided to remove it to not create stuttering code), see the two
important `TODO` comments left in the code.

Fixes #6392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Grids: basic minmax support concrete-utopia/utopia
1 participant
@ruggi