Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly add a requirement for elementsToRerender in canvas strategy output #6372

Closed
Rheeseyb opened this issue Sep 16, 2024 · 0 comments · Fixed by #6408
Closed

Possibly add a requirement for elementsToRerender in canvas strategy output #6372

Rheeseyb opened this issue Sep 16, 2024 · 0 comments · Fixed by #6408
Assignees

Comments

@Rheeseyb
Copy link
Contributor

Rheeseyb commented Sep 16, 2024

When adding new canvas strategies it is very easy to forget to use the setElementsToRerenderCommand when required (which is most of the time). The CustomStrategyState already has a field elementsToRerender. It might make more sense to remove the command, and to bring elementsToRerender up into the StrategyApplicationResult to enforce a conscious decision around whether elements need to be re-rendered as a result of applying this strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants