Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder grid #6355

Closed
ruggi opened this issue Sep 12, 2024 · 0 comments · Fixed by #6351
Closed

Reorder grid #6355

ruggi opened this issue Sep 12, 2024 · 0 comments · Fixed by #6351
Assignees

Comments

@ruggi
Copy link
Contributor

ruggi commented Sep 12, 2024

No description provided.

@ruggi ruggi self-assigned this Sep 12, 2024
@ruggi ruggi mentioned this issue Sep 12, 2024
@ruggi ruggi closed this as completed in 68d1378 Sep 13, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
**Problem:**
Moving grid elements currently means only explicitly setting their grid
positioning props (row, column), which has two issues:
1. it does not reorder elements in the code nor the navigator
2. it does not leverage the grid intrinsic ordering, those properties
should be set only when strictly necessary

**Fix:**

Extend the strategy so that it prioritizes reordering instead of
explicit positioning, and even in the cases where it needs to use
row/col props it will still reorder based on the starting index position
in the grid hierarchy (left-right, top-bottom).

Fixes #6355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant