Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ipv4 resolution only for local dev #4837

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Set ipv4 resolution only for local dev #4837

merged 3 commits into from
Feb 6, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Feb 5, 2024 •
edited
Loading

Problem:
We don't need to set the dns resolution order for anything else other than local dev

Fix:
Check server env before setting the resolution order

This requires adding this line to your utopia-remix/.env:

SERVER_ENV="local"

@liady liady changed the title Fix/ipv4 resolution Set ipv4 resolution only for local dev Feb 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024 •
edited
Loading

Try me

@liady liady requested a review from ruggi February 5, 2024 15:33
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 5, 2024

Job #10230: Bundle Size — 62.35MiB (~-0.01%).

99cbbb3(current) vs 794431b master#10224(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10230		      Baseline
Job #10224
Regression  Initial JS 35.39MiB(~+0.01%) 35.39MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.23% 21.77%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4407 4407
No change  Duplicate Modules 490 490
No change  Duplicate Code 30.7% 30.7%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10230		      Baseline
Job #10224
Regression  JS 62.34MiB (~+0.01%) 62.34MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10230 report View fix/ipv4-resolution branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Performance test results:
(Chart1)
(Chart2)

@liady liady marked this pull request as ready for review February 5, 2024 16:50
@liady liady merged commit b8e42f2 into master Feb 6, 2024
15 of 16 checks passed
@liady liady deleted the fix/ipv4-resolution branch February 6, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrmendy bkrmendy bkrmendy approved these changes

@ruggi ruggi ruggi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liady @ruggi @bkrmendy