Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remix toolbar and scene label mouse handling #4831

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Remix toolbar and scene label mouse handling #4831

merged 1 commit into from
Feb 5, 2024

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Feb 2, 2024

Description:
Remix buttons listen to mouse down, even though they should listen to click.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024 •
edited
Loading

Try me

@gbalint gbalint marked this pull request as ready for review February 2, 2024 16:35
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 2, 2024 •
edited
Loading

Job #10206: Bundle Size — 62.34MiB (+0.02%).

5e01501(current) vs 794431b master#10182(baseline)

Warning

Bundle contains 66 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 2 regressions
                 Current
Job #10206		      Baseline
Job #10182
Regression  Initial JS 35.38MiB(+0.03%) 35.37MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.76% 20.18%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4407 4407
No change  Duplicate Modules 490 490
Regression  Duplicate Code 30.7%(+0.03%) 30.69%
No change  Packages 462 462
No change  Duplicate Packages 65 65
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10206		      Baseline
Job #10182
Regression  JS 62.33MiB (+0.02%) 62.31MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10206 report View fix/remix-nav-events branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024 •
edited
Loading

Performance test results:
(Chart1)
(Chart2)

@gbalint gbalint merged commit 3326a42 into master Feb 5, 2024
16 checks passed
@gbalint gbalint deleted the fix/remix-nav-events branch February 5, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsbajorics balazsbajorics balazsbajorics approved these changes

@ruggi ruggi ruggi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbalint @ruggi @balazsbajorics