Now store the session as JSON. #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a `session_json` column to `persistent_session`. - `PersistentSessionFields` now includes the type for `session_json`. - `sessionToTable` now takes a value of type `Value` to populate the `session_json` column with. - Added `sessionMapToJSON` to validate the `SessionMap` value we expect as well as to construct the JSON that goes into `session_json`. - `lookupSession` backfills the `session_json` column if it is null. - `insertSession` and `replaceSession` functions of the `Storage SessionStorage` instance now streamline in a value for the `session_json` column.
seanparsons
requested review from
gbalint,
Rheeseyb,
ruggi,
balazsbajorics,
liady and
bkrmendy
seanparsons
changed the title
Job #10216: Bundle Size — 62.34MiB (~-0.01%).
Warning Bundle contains 66 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #10216 report View feature/session-stored-as-json branch activity View project dashboard |
ruggi
approved these changes
Feb 2, 2024
|
Performance test results: |
Rheeseyb
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Our server serialises the content of the session with a binary serialisation which means that it's difficult for anything else to look into the content of that session even if it has access to the database.
Fix:
This adds an additional column
session_jsonto thepersistent_sessiontable, which is populated at these points:session_jsoncolumn is NULL.The
session_jsoncolumn is stored as the PostgreSQL nativejsonbtype which means it can be manipulated directly in PostgreSQL itself, rather than being stored as a text type.Commit Details:
session_jsoncolumn topersistent_session.PersistentSessionFieldsnow includes the type forsession_json.sessionToTablenow takes a value of typeValueto populate thesession_jsoncolumn with.sessionMapToJSONto validate theSessionMapvalue we expect as well as to construct the JSON that goes intosession_json.lookupSessionbackfills thesession_jsoncolumn if it is NULL.insertSessionandreplaceSessionfunctions of theStorage SessionStorageinstance now streamline in a value for thesession_jsoncolumn.