Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output_timeout should be configurable #136

Open
sbrugman opened this issue Feb 1, 2020 · 0 comments
Open

output_timeout should be configurable #136

sbrugman opened this issue Feb 1, 2020 · 0 comments

Comments

@sbrugman
Copy link

sbrugman commented Feb 1, 2020

The variable output_timeout is now a hardcoded constant:

nbval/nbval/plugin.py

Line 336 in 232d249

self.output_timeout = 5

For testing large outputs, such as notebook widgets, the 5 seconds are not sufficient.
Making the variable configurable would solve that issue.
sbrugman added a commit to ydataai/ydata-profiling that referenced this issue Feb 1, 2020
@sbrugman
Decouple notebooks and notebook tests.
023bd70 
- Display no progress bar for disabled modules (e.g. individual correlations).
- Disable missing plots in minimal mode
- Bump `coverage` requirement
- One test hangs on issue in nbval:
computationalmodelling/nbval#136
sbrugman added a commit to ydataai/ydata-profiling that referenced this issue Feb 2, 2020
@sbrugman
Progress bar implementation (#345)
606480d 
* Progress bar implementation

- Feature as requested in #224
- Test for #282
- Many thanks @marco-cardoso for your initial implementation #225
- Display no progress bar for disabled modules (e.g. individual correlations).
- Update requirements, notebooks, docs, examples, linting

* Decouple notebooks and notebook tests. One test hangs on issue in nbval:
computationalmodelling/nbval#136

* Disable missing plots in minimal mode

* Create additional demo with Chicago employees data

* Compartmentalize column sorting in describe module
@vidartf vidartf mentioned this issue Feb 12, 2020
Closed
chanedwin pushed a commit to chanedwin/pandas-profiling that referenced this issue Oct 11, 2020
@sbrugman
Progress bar implementation (ydataai#345)
8dca684 
* Progress bar implementation

- Feature as requested in ydataai#224
- Test for ydataai#282
- Many thanks @marco-cardoso for your initial implementation ydataai#225
- Display no progress bar for disabled modules (e.g. individual correlations).
- Update requirements, notebooks, docs, examples, linting

* Decouple notebooks and notebook tests. One test hangs on issue in nbval:
computationalmodelling/nbval#136

* Disable missing plots in minimal mode

* Create additional demo with Chicago employees data

* Compartmentalize column sorting in describe module
@renefritze renefritze mentioned this issue Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make output_timeout configurable
1 participant
@sbrugman