PSHEASSN-517: Handle fees block in Event Info page

[ahed-compucorp]

Overview

This PR is to alter the fee block in the Event Info page to show the right price field values depending on the current user's membership.

Created price set with two price field and each one has two options then configured members only event.

Before - Event Info

Event Info page will show all fee items.

After - Event Info

Event Info page will show fee items depending on the user's membership - below you will see non member price field values.

Before - Event Registration

There is no checkbox options.

After - Event Registration

Checkbox options are visible.

Technical Details

I used the hook_civicrm_pageRun hook to alter the Event Info page, but the values are already proccessed and sent to Smarty template.

Below you can see $_template->_tpl_vars['feeBlock'] value:

array(4) {
  ["value"]=>
  array(6) {
    [1]=>
    string(0) ""
    [2]=>
    string(12) "50.000000000"
    [3]=>
    string(12) "20.000000000"
    [4]=>
    string(0) ""
    [5]=>
    string(12) "50.000000000"
    [6]=>
    string(12) "20.000000000"
  }
  ["label"]=>
  array(6) {
    [1]=>
    string(26) "Event Fee - CheckBox Group"
    [2]=>
    string(23) "Non-member fee CheckBox"
    [3]=>
    string(19) "Member fee CheckBox"
    [4]=>
    string(23) "Event Fee - Radio Group"
    [5]=>
    string(20) "Non-member fee Radio"
    [6]=>
    string(16) "Member fee Radio"
  }
  ["lClass"]=>
  array(6) {
    [1]=>
    string(28) "price_set_option_group-label"
    [2]=>
    string(22) "price_set_option-label"
    [3]=>
    string(22) "price_set_option-label"
    [4]=>
    string(28) "price_set_option_group-label"
    [5]=>
    string(22) "price_set_option-label"
    [6]=>
    string(22) "price_set_option-label"
  }
  ["isDisplayAmount"]=>
  array(6) {
    [1]=>
    string(1) "1"
    [2]=>
    string(1) "1"
    [3]=>
    string(1) "1"
    [4]=>
    string(1) "1"
    [5]=>
    string(1) "1"
    [6]=>
    string(1) "1"
  }
}

As you can see the fee items include both price fields and price field values and it is bad idea to guess the ID from the label. Instead, the method getFeeItems will return fee items with their ID then altered $_template->_tpl_vars['feeBlock'] to hide price field values depending on user's membership.

Comments

This PR contains these small fixes/updates :

• Fixed undefined property in BuildForm hook
• Fixed a typo in the empty condition.
• Fixed the missing checkbox options issue.
• Updated multi-select label

[omarabuhussein]

I really don't understand the "technical details" of this ticket that are related to this commit 8da8e62 and not sure what are you trying to solve here, can you maybe try to word it differently, can you also try to write what is the issue from the user perspective in the "before" and "after" sections, because the screenshots alone does not tell much.

[omarabuhussein]

I would alter this to :

  if ($isCheckboxElement) {
   // for civicrm versions >= 5.35.0
    $priceFieldValueID = $element->getAttribute('id');
  }
  else {
    // for civicrm versions < 5.35.0
    $priceFieldValueID = $element->getAttribute('value');
  }

[ahed-compucorp]

Sorry, I've updated my PR,
This is not CiviCRM 5.35.1 issue, I tried it on 5.28 and it seems that $element->getAttribute('value') for checkbox will always return "1"
Hence we need to use the id attribute.