-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/configurations #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The basic configuration file. I also plan to add description
and type
in the file, outside data
. I imagine these two things would be very helpful for the form
. i.e. if we want to modify the items in the viewer, type=int
items can be represented as slider
s.
could you maybe teach me how to add that?
I think the reason for the build error is that: I developed this package using |
Gonna merge already, just fix the docs error on your next PR @ZacZhangzhuo |
What type of change is this?
controller_config
andviewer_config
A basic configuration buildup for loading the configuration (as well as the
.viewer
zip file in the future). I try to respect the currentcompas.data
architecture, but I might still need a lead though for a good succession.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.