Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/configurations #5

Merged
merged 12 commits into from
Dec 7, 2023
Merged

Feature/configurations #5

merged 12 commits into from
Dec 7, 2023

Conversation

ZacZhangzhuo
Copy link
Collaborator

@ZacZhangzhuo ZacZhangzhuo commented Dec 7, 2023

What type of change is this?

  • Configurations: controller_config and viewer_config

A basic configuration buildup for loading the configuration (as well as the .viewer zip file in the future). I try to respect the current compas.data architecture, but I might still need a lead though for a good succession.


Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basic configuration file. I also plan to add description and type in the file, outside data. I imagine these two things would be very helpful for the form. i.e. if we want to modify the items in the viewer, type=int items can be represented as sliders.

could you maybe teach me how to add that?

@ZacZhangzhuo
Copy link
Collaborator Author

I think the reason for the build error is that:

I developed this package using compas_2. while GitHub action only use the version 1 from pip

@ZacZhangzhuo ZacZhangzhuo self-assigned this Dec 7, 2023
@Licini
Copy link
Collaborator

Licini commented Dec 7, 2023

Gonna merge already, just fix the docs error on your next PR @ZacZhangzhuo

@Licini Licini merged commit 082b94f into main Dec 7, 2023
10 of 11 checks passed
@ZacZhangzhuo ZacZhangzhuo deleted the feature/configurations branch December 27, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants