Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN failing #46

Open
2 tasks
ernestguevarra opened this issue Apr 25, 2021 · 2 comments · May be fixed by #49
Open
2 tasks

CRAN failing #46

ernestguevarra opened this issue Apr 25, 2021 · 2 comments · May be fixed by #49
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ernestguevarra
Copy link
Member

ernestguevarra commented Apr 25, 2021

see https://cran.r-project.org/web/checks/check_results_oxcovid19.html

specifically:

These are connected to failing examples on function for citing sources - something changed again in the website and/or the database?

@ernestguevarra ernestguevarra added the bug Something isn't working label Apr 25, 2021
@ernestguevarra ernestguevarra added this to the CRAN updates milestone Apr 25, 2021
@ernestguevarra ernestguevarra self-assigned this Apr 25, 2021
@ernestguevarra
Copy link
Member Author

ernestguevarra commented Apr 25, 2021

Email from CRAN:

Dear maintainer,
Please see the problems shown on https://cran.r-project.org/web/checks/check_results_oxcovid19.html.

Please correct before 2021-05-07 to safely retain your package on CRAN.

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with an informative message
if the resource is not available or has changed (and not give a check warning nor error).'

This needs correction whether or not the resource recovers.

The CRAN Team

@ernestguevarra
Copy link
Member Author

ernestguevarra commented Apr 25, 2021

Have tried to replicate the error locally but checks come off as OK with no errors and warnings.

Will need to build in try and/or tryCatch in functions that query and/or retrieve from database. Attempt 3 times before letting the function fail gracefully as required by CRAN.

@ernestguevarra ernestguevarra linked a pull request May 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant