Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Multiple substitutions specified in non-positional format of string resource" warnings #5774

Open
nicolas-raoul opened this issue Jul 16, 2024 · 4 comments · May be fixed by #5776
Open

"Multiple substitutions specified in non-positional format of string resource" warnings #5774

nicolas-raoul opened this issue Jul 16, 2024 · 4 comments · May be fixed by #5776
Labels
bug localization

Comments

@nicolas-raoul
Copy link
Member

I see these warnings when building a fresh clone:

app/src/main/res/values-zh-rTW/strings.xml:628:2: Multiple substitutions specified in non-positional format of string resource string/wikipedia_instructions_step_6. Did you mean to add the formatted="false" attribute?
app/src/main/res/values-sl/strings.xml:111:2: Multiple substitutions specified in non-positional format of string resource string/contribution_state_in_progress. Did you mean to add the formatted="false" attribute?
app/src/main/res/values-sl/strings.xml:620:2: Multiple substitutions specified in non-positional format of string resource string/wikipedia_instructions_step_6. Did you mean to add the formatted="false" attribute?
@sivaraam sivaraam linked a pull request Jul 17, 2024 that will close this issue
Open
@sivaraam
Copy link
Member

I raised an MR #5776 to handle this. Kindly check @nicolas-raoul Let me know your thoughts about testing the change visually.

Also, handled one of the cases by editing the translatewiki entry. Let me know if that looks good.

@nicolas-raoul
Copy link
Member Author

No idea either where it is used, the copy the wikitext to the clipboard button does not seem to use it.

How about trying to remove these strings? Either they can be removed without impacting anything, or we will learn where they are used. :-)
Removing app/src/main/res/layout/dialog_add_to_wikipedia_instructions.xml makes compilation fail without saying why. :-/

@sivaraam
Copy link
Member

I think the same was introduced via #3783 which is a PR that fixes #872. So, I think we need a Nearby uploaded image to cross-check if that functionality works fine or not. Would you be able to cross check this, Nicolas?

@nicolas-raoul
Copy link
Member Author

I just uploaded a picture via Nearby but do not see the Wikipedia icon:

Screenshot_20240725-215633.png

I remember seeing such an icon in the past though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark a string as not for formatting commons-app/apps-android-commons
2 participants
@nicolas-raoul @sivaraam