Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when building in angular 14 project #348

Closed
Gillardo opened this issue Aug 17, 2022 · 2 comments
Closed

Warning when building in angular 14 project #348

Gillardo opened this issue Aug 17, 2022 · 2 comments

Comments

@Gillardo
Copy link

This was ok when i was using angular 13 which i believe targets es2018, but since updating i am getting these errors.

image

Here is my tsconfig

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "downlevelIteration": true,
    "experimentalDecorators": true,
    "moduleResolution": "node",
    "importHelpers": true,
    "target": "es2020",
    "module": "es2020",
    "lib": [
      "es2018",
      "dom"
    ],
  }
}
@Gillardo Gillardo changed the title Issuing building with this es2020 in angular 14 project Issue building with this es2020 in angular 14 project Aug 17, 2022
@Gillardo Gillardo changed the title Issue building with this es2020 in angular 14 project Issue building with es2020 in angular 14 project Aug 17, 2022
@Gillardo Gillardo changed the title Issue building with es2020 in angular 14 project Warning when building in angular 14 project Aug 17, 2022
@commenthol
Copy link
Owner

Hi @Gillardo,
As said this project offers both ESM and CJS via package.json exports.
If you think the issue is unrelated to your project setup, please provide a fix via a PR.

@Gillardo
Copy link
Author

Gillardo commented Aug 28, 2022

Sorry but i do not think this is correct. It also states this on the deepmerge github
TehShrike/deepmerge#250

Which as i stated, was one of the errors when using your library
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants