Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set ruff as VSCode defaultFormatter for python #33150

Conversation

andiradulescu
Copy link
Contributor

@andiradulescu andiradulescu commented Jul 31, 2024

Proof of concept on setting ruff as VSCode defaultFormatter for python.

"Format Document" has been run on can_replay.py.

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@adeebshihadeh
Copy link
Contributor

We intentionally don't use a formatter and keep our linter relatively relaxed. https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md#what-doesnt-get-merged

@andiradulescu andiradulescu deleted the vscode-ruff-as-default-formatter branch August 3, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants