Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scons: Remove acados Include Paths from Global #33088

Closed

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Jul 26, 2024

Removes the following global include paths from SCons and relocates them to the specific modules that require them:

  • #third_party/acados/include
  • #third_party/acados/include/blasfeo/include
  • #third_party/acados/include/hpipm/include

This change improves build performance by reducing the number of directories the compiler searches globally.

Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@adeebshihadeh
Copy link
Contributor

Can you post before/after for these PRs? There's a tradeoff being made here on using the same environment everywhere (connivence) and time. If it's costing a lot of time, then I think these are worth it.

I propose we do one big PR with all the SCons optimizations, then evaluate whether it's worth it. If it is and the PR is too big, we can split it up then.

@deanlee
Copy link
Contributor Author

deanlee commented Jul 26, 2024

I agree, it's not worth it for these small changes.

@deanlee deanlee closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants