camerad: add CameraConfig struct for initializing CameraState in constructor

[deanlee]

reopen #33034

[github-actions]

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

• Convert your PR to a draft unless it's ready to review
• Read the contributing docs
• Before marking as "ready for review", ensure:
  • the goal is clearly stated in the description
  • all the tests are passing
  • the change is something we merge
  • include a route or your device' dongle ID if relevant

[adeebshihadeh]

trigger-jenkins

[adeebshihadeh]

Failed on OX03C10

[deanlee]

Strange, but I don't think this PR is the likely cause. It only initializes a few parameters for the camera before opening it. However, I'll double-check later.

[deanlee]

Failed on OX03C10

I ran test_camerad.py on device (OX03C10) multiple times without errors. that error report might be due to a flaky test?

[adeebshihadeh]

This test is quite reliable, but let's try again.

trigger-jenkins

[deanlee]

The issue should be identified now. It's an initialization problem.

Previously, the CameraState had no constructor and did not manage its own initialization, depending on MultiCameraState cameras = {}; to set its member variables to zero.

This pull request introduces a constructor for CameraState, meaning that CameraState must now take responsibility for initializing its own member variables. Otherwise, the member variables could contain corrupt data.

I have committed the fix. The CameraState class now properly manages its own initialization, which should help it pass the test and improve overall reliability.

[adeebshihadeh]

trigger-jenkins