Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op tool helper #33053

Merged
merged 9 commits into from
Jul 24, 2024
Merged

op tool helper #33053

merged 9 commits into from
Jul 24, 2024

Conversation

maxime-desroches
Copy link
Contributor

@maxime-desroches maxime-desroches commented Jul 24, 2024

can use it by adding alias op='source <YOUR OPENPILOT DIR>/tools/op.sh "$@"' to your .bashrc

  • need to check for git submodules

Install it by running tools/op.sh --install then open a new shell and use op

@github-actions github-actions bot added the tools label Jul 24, 2024
@maxime-desroches maxime-desroches marked this pull request as ready for review July 24, 2024 04:46
@maxime-desroches maxime-desroches merged commit f60dfd4 into master Jul 24, 2024
18 of 19 checks passed
@maxime-desroches maxime-desroches deleted the op_tool branch July 24, 2024 04:47
@sshane
Copy link
Contributor

sshane commented Jul 24, 2024

I have pyenv still, set up to be my global python, is this expected to not work?

Can we also add op cabana?

batman@workstation-shane:~/openpilot$ op build
bash: /home/batman/openpilot/.venv/bin/activate: No such file or directory

Can't activate venv. Have you ran 'op install' ?

@maxime-desroches
Copy link
Contributor Author

@sshane I will add cabana.

For the venv, I think we should follow the standard of one .venv per python project. Running install_python_dependencies.sh creates that .venv for you.

Also, uv offers almost the same things as pyenv but 100000x faster. You can just run uv python install 3.12.4

@adeebshihadeh
Copy link
Contributor

I think we can support skipping the venv sourcing if .venv doesn't exist? You're on your own though if things aren't setup properly.

@sshane
Copy link
Contributor

sshane commented Jul 24, 2024

A warning at worst is fine with me, my setup may be weird, but I prefer a global install as I use it for notebooks, in various PyCharm projects, etc.

@adeebshihadeh
Copy link
Contributor

Let's take this to the Discord thread.

gregjhogan pushed a commit that referenced this pull request Jul 29, 2024
* op

* change this

* juggler

* options

* fix

* submodules

* typo

* venv

* clean + install
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
* op

* change this

* juggler

* options

* fix

* submodules

* typo

* venv

* clean + install
old-commit-hash: f60dfd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants