-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3 Screen Too Bright @ Night #33041
Comments
It's not an intermittent issue at all, for me at least. Pick any route at night with this dongle |
Night driving only possible with manual brightness setting currently |
Commenting to say I am having this issue as well recently. Blinding at night at like 100%. Manually turn down. Then during day, can't see screen unless I shade it from the sun to turn it back up again because I cranked it down the night before. |
Can you guys test |
@adeebshihadeh looks like that helped! Not as dim as I personally keep my infotainment, but it was enough that it wasn't blinding. Route: 5130484aa8069bad/000000c9--4b7e4e53c6 |
@adeebshihadeh are you looking for any other users to test, or any other routes to merge this? |
So that isn't a mergable branch, it's just a test. Now that it's been tested, I'll come up with a mergable branch for you guys to test soon. |
I can also test in a couple of days. Just really busy the last week... |
Worked well on this route today |
The more I use this branch the more it seems like it's just darkening the input from the cameras and not the actual screen. If I open the sidebar or go into settings it's just as bright as not being on this branch. Looking back at old footage from previous releases, the screen was a lot darker. Is there a way to reinvestigate this as an auto brightness issue instead of the gamma input on the cameras? |
What footage? You can't tell this from the device's logs, unless you mean recording a video of the device with your phone? |
Yes looking at old footage I recorded of the comma 3 and from my own memory, it was a lot dimmer. |
Can confirm the UI is bright. Screen is still bright at night. |
Also confirming. How does this go on so long? Lol, does it not get dark in San Diego? It's unusable at night without cranking it way down. Then you can't see it in the morning without covering it with your hand to make it dark enough to see the settings to turn it back up. |
The screen is the brightest at midnight. This was at 2400-0100 w. |
Here's an example of auto brightness mostly working. Seems to work best when there's changes to the brightness. In this route we start in my garage, then go to a sunset drive into twilight. It starts to dim with the sunset correctly until I get on the highway in which it full brights for a mile or two, then starts to auto dim again correctly: 5130484aa8069bad/0000012a--3c9d04250a |
Describe the bug
Since installing 0.9.7 screen brightness at night on the C3 has been way too bright. Usually the night compensation for brightness works well, seems to have changed w/ 0.9.7.
Route below is an example of a bad screen brightness at night.
Whole route has the issue happening.
Provide a route where the issue occurs
4ecfcac756318cbf/00000035--99d3637ece
openpilot version
0.9.7, release3
Additional info
Fixing the brightness compensation is good but I would suggest adding an alternative brightness toggle. The user would be able to easily override screen brightness settings if they do not like stock brightness settings.
The text was updated successfully, but these errors were encountered: