Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3 Screen Too Bright @ Night #33041

Open
jsegill opened this issue Jul 22, 2024 · 16 comments
Open

C3 Screen Too Bright @ Night #33041

jsegill opened this issue Jul 22, 2024 · 16 comments
Labels
Milestone

Comments

@jsegill
Copy link

jsegill commented Jul 22, 2024

Describe the bug

Since installing 0.9.7 screen brightness at night on the C3 has been way too bright. Usually the night compensation for brightness works well, seems to have changed w/ 0.9.7.

Route below is an example of a bad screen brightness at night.

Whole route has the issue happening.

Provide a route where the issue occurs

4ecfcac756318cbf/00000035--99d3637ece

openpilot version

0.9.7, release3

Additional info

Fixing the brightness compensation is good but I would suggest adding an alternative brightness toggle. The user would be able to easily override screen brightness settings if they do not like stock brightness settings.

@jsegill jsegill added the bug label Jul 22, 2024
@adeebshihadeh adeebshihadeh added this to the 0.9.8 milestone Jul 22, 2024
@CruiseBrantley
Copy link
Contributor

It's not an intermittent issue at all, for me at least. Pick any route at night with this dongle 149d6f706527cfe1
Here's 1 example 149d6f706527cfe1/00000115--907e342143
Essentially just stuck at 100% brightness it seems, I only notice it at night (every time) but possibly any route just not being noticeable during the day.

@jkbkster
Copy link

Night driving only possible with manual brightness setting currently

@wired4sound
Copy link

wired4sound commented Jul 29, 2024

Commenting to say I am having this issue as well recently.

Blinding at night at like 100%. Manually turn down. Then during day, can't see screen unless I shade it from the sun to turn it back up again because I cranked it down the night before.

@adeebshihadeh
Copy link
Contributor

Can you guys test installer.comma.ai/commaai/fix-too-bright?

@MarcoTheDingo
Copy link
Contributor

@adeebshihadeh looks like that helped! Not as dim as I personally keep my infotainment, but it was enough that it wasn't blinding. Route: 5130484aa8069bad/000000c9--4b7e4e53c6

@MarcoTheDingo
Copy link
Contributor

@adeebshihadeh are you looking for any other users to test, or any other routes to merge this?

@adeebshihadeh
Copy link
Contributor

So that isn't a mergable branch, it's just a test. Now that it's been tested, I'll come up with a mergable branch for you guys to test soon.

@jsegill
Copy link
Author

jsegill commented Aug 27, 2024

I can also test in a couple of days. Just really busy the last week...

@jsegill
Copy link
Author

jsegill commented Sep 12, 2024

Worked well on this route today 4ecfcac756318cbf/00000000--abb1191d75/0

@MarcoTheDingo
Copy link
Contributor

The more I use this branch the more it seems like it's just darkening the input from the cameras and not the actual screen. If I open the sidebar or go into settings it's just as bright as not being on this branch.

Looking back at old footage from previous releases, the screen was a lot darker. Is there a way to reinvestigate this as an auto brightness issue instead of the gamma input on the cameras?

@adeebshihadeh
Copy link
Contributor

Looking back at old footage from previous releases

What footage? You can't tell this from the device's logs, unless you mean recording a video of the device with your phone?

@MarcoTheDingo
Copy link
Contributor

Yes looking at old footage I recorded of the comma 3 and from my own memory, it was a lot dimmer.

@jsegill
Copy link
Author

jsegill commented Sep 14, 2024

Can confirm the UI is bright. Screen is still bright at night.

@wired4sound
Copy link

Also confirming. How does this go on so long? Lol, does it not get dark in San Diego? It's unusable at night without cranking it way down. Then you can't see it in the morning without covering it with your hand to make it dark enough to see the settings to turn it back up.

@jsegill
Copy link
Author

jsegill commented Sep 18, 2024

The screen is the brightest at midnight. This was at 2400-0100 w. Screen-Too-Bright. Non primary OP driver commented "it's as bright as the sun"... a bit dramatic but wanted to share the raw opinion of non daily OP user. 4ecfcac756318cbf/00000016--7005cf51a2/0

@MarcoTheDingo
Copy link
Contributor

Here's an example of auto brightness mostly working. Seems to work best when there's changes to the brightness. In this route we start in my garage, then go to a sunset drive into twilight. It starts to dim with the sunset correctly until I get on the highway in which it full brights for a mile or two, then starts to auto dim again correctly: 5130484aa8069bad/0000012a--3c9d04250a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants