Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camerad: move camera exposure logic to CameraExposure Class #33018

Closed
wants to merge 1 commit into from

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Jul 19, 2024

Refactors the camera exposure logic by encapsulating related functions and variables into the new CameraExposure class. This update ensures that camera_qcom2.cc and camera_qcom2.h are focused solely on V4L2 camera-related operations.

The changes involve straightforward encapsulation, with the functionality of the code remaining unchanged to facilitate easier review.

Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@adeebshihadeh
Copy link
Contributor

trigger-jenkins

@deanlee deanlee marked this pull request as draft July 25, 2024 21:08
@deanlee
Copy link
Contributor Author

deanlee commented Jul 29, 2024

has conflicts with master. closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants