Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOM importer does not check for missing slices / inconsistent slice spacing #1301

Closed
MikeOver1 opened this issue Apr 14, 2020 · 3 comments
Closed

Comments

@MikeOver1
Copy link
Contributor

Volumes with inconsistent slice spacing should probably raise a ValidationError.

@pkcakeout
Copy link
Contributor

I was wondering a little but. This will bite us again if we make this too strict. I am pretty sure that right we want the ValidationError but I also remember that is was super-hard in our old application to read scans where "one slice was missing" and we were frantically searching for a way to do it in our applications. Therefore, we could say that the current way it works "reading scans with missing slices" is a feature as well.

Just want to dump this here as a word of caution. This current "sloppyness" is a nice to have feature - especially for research. I have no idea how to retain this in one case though and disable it in the other. Maybe implement an internal flag for this to enable "sloppy" mode on demand? No idea.

Like I said, just a word of caution. Not sure what to do about this.

@bramvanginneken
Copy link
Member

Instead of sort of redoing what we’ve done years ago, getting archives and dicom tools right, let’s not reinvent but discuss with Colin and use his approach from the past.

@jmsmkn
Copy link
Member

jmsmkn commented Mar 8, 2021

Transferred to DIAGNijmegen/rse-panimg#7

@jmsmkn jmsmkn closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants