Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] nested node #150

Closed
PladsElsker opened this issue Mar 18, 2023 · 4 comments
Closed

[feature request] nested node #150

PladsElsker opened this issue Mar 18, 2023 · 4 comments

Comments

@PladsElsker
Copy link

I wonder what would be needed to implement a nested/composite node that can run and edit a sub-workflow.

What I mean is something like the grouped node in blender.

It would be nice to be able to save them as custom nodes as well to load them later on.

It would also be nice to allow nested nodes to be used in nested nodes themselves.

I saw that there's a way to make your own custom js extension to run whatever code is needed in ComfyUI, I thought that maybe there was a way to implement the missing code to be able to use all the functionalities of litegraphjs to make this nested node thing possible.

Any concrete ideas on how to achieve this?

@PladsElsker
Copy link
Author

PladsElsker commented Mar 18, 2023

I thought about making a node that just calls the API, but that definitely won't work as you can only add a prompt to the queue.

Furthermore, there's a lot of data forwarding for the inputs and outputs that would be needed, and so I think making a node that calls the API for that is a bad idea.

@Kuinox
Copy link

Kuinox commented Jun 3, 2023

I too would like nested nodes.

@ltdrdata
Copy link
Collaborator

ltdrdata commented Jun 3, 2023

I too would like nested nodes.

There are 2 approaches are developing.

This is subgraph feature. This will be included built-in, eventually.

#724

And this is a workflow component feature. This is an experimental project. Currently, you can use as an extensiom. But, I am not decided, yet.

https://github.com/ltdrdata/ComfyUI-Workflow-Component

Usability of each approaches are little bit different.

@comfyanonymous
Copy link
Owner

#1776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants