-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer File.getCanonicalFile over Path.normalize #79
Prefer File.getCanonicalFile over Path.normalize #79
Conversation
This comment has been minimized.
This comment has been minimized.
3e43f15
to
8f64cf9
Compare
The former normalizes Windows 8.3 paths to long paths, whereas the latter doesn't.
8f64cf9
to
603dc76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Having a test for it, would make me more comfortable.
Same for me, actually… I'll try to add one the next time I'll boot my Windows machine. |
Ok, I added a test… and now I'm shared about merging this 😬
But a worse issue is that it seems that
And fwiw, a similar issue can be reproduced on macOS (with its "case-insensitive but case-preserving" file systems), using just the case:
|
Do you mean "scared"?
Oh, as I commented on #78, I'd rather remove any dependency on disk state, and I was under the impression, you're going to always normalize to the long form. In that regard, I don't understand the test case, at least, it test something different.
Better, we don't merge this. |
It'd be better not to merge, yes. (And it seems there's a need for a library providing true canonical paths, without those caching quirks…) |
Fixes #78.