Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce and fix class too large error on large java repo #3944

Open
lihaoyi opened this issue Nov 12, 2024 · 0 comments
Open

Reproduce and fix class too large error on large java repo #3944

lihaoyi opened this issue Nov 12, 2024 · 0 comments

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Nov 12, 2024

Converting https://github.com/iluwatar/java-design-patterns to Mill using #3756, we get a class too large error. Wrapping the Discover map keys in a proper anonymous class (rather than a lambda) seems to fix it. But I haven't managed to get a standalone repro on the problem, even with builds with 1000 modules, more than the link repo's count of 172

We really should to ensure we can reproduce the issue before merging the fix, so we can validate it works and continue working as part of our test suites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant