-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSR-compatible #4
Comments
PSR-what? Some? All? What does this lib gain by following PSR guidelines besides the fact you can use a nice buzzword in the read me? |
Buzzword compliance, never underestimate it. :) Especially the PHP community needs some formalism. |
@PeeHaa what does your comment gain to this lib? |
I just don't like the blanket statements like: Use PSR without any reasoning. And without elaborating what is gained and / or what PSR you like to see implemented and why. |
@PeeHaa ok. As I remember on the time, when I commented it, it was mainly to have good code style. Only PSR1 and PSR2 was available. PSRs are good same as PEPs in python. Standards also good. And as comrade McConnell said: "Code read more often than writes". |
PSR-1 and -2 are all about coding standards and as has been mentioned it's no huge benefit other than removing the need to make up your own and consistency with other libraries. You missed PSR-0, which is all about naming namespaces, classes and files in such a way that you can use the default SPL autoloader with no custom autoloader required. That is definitely worth having, and really goes hand-in hand with composer support, and I suspect what this vague ticket was meant to be about. |
Make code PSR-compatible.
The text was updated successfully, but these errors were encountered: