Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild() doesn't remove nodes for moderate face count #20

Open
braneof opened this issue Aug 8, 2017 · 1 comment
Open

rebuild() doesn't remove nodes for moderate face count #20

braneof opened this issue Aug 8, 2017 · 1 comment

Comments

@braneof
Copy link

braneof commented Aug 8, 2017

I'm rotation an object 90 degrees and back, and at each step I call octree.rebuild(). It's adding nodes correctly (as far as I can tell), but it rarely removes old nodes. So when it gets back to it's original orientation the octree is a mess.

This problem doesn't occur when the face count is very low. It works fine for a model with 14 faces, but the problem occurs with 519 faces.

My system is not very powerful, so it might not occur with this low face count for other people.

Starting octree:
image

Ending octree (after rotate 90 and back):
image

@collinhover
Copy link
Owner

collinhover commented Aug 9, 2017

Thanks for the bug report! I'm not actively developing THREE Octree anymore, but if you want to submit a pull request for a fix, I'll review and merge it in.

You may also want to try to remove the object and add it back in after rotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants