Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if I navigate during editing I exit edit mode #121

Open
djay opened this issue Aug 1, 2024 · 2 comments · Fixed by #78
Open

if I navigate during editing I exit edit mode #121

djay opened this issue Aug 1, 2024 · 2 comments · Fixed by #78

Comments

@djay
Copy link
Member

djay commented Aug 1, 2024

No description provided.

@MAX-786
Copy link
Member

MAX-786 commented Aug 1, 2024

@djay is it different from #69 ? , if not then I think we discussed this and it is already fixed, like in here whenever you change the url (i.e. navigate from one location to another) it moves you out from editing.

if (isRoutingWithHash) {
const pathname = hash.replace('#!', '');
history.push(`${pathname}`);
} else {
history.push(`${givenUrlObject.pathname}`);
}
},

@djay
Copy link
Member Author

djay commented Aug 2, 2024

@MAX-786 ok just connect it to the old pr and I will test it again.
This was a draft ticket so not sure when I created it.

@MAX-786 MAX-786 linked a pull request Aug 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants