Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Python3 Support #9

Open
1letter opened this issue Jul 15, 2019 · 12 comments
Open

Missing Python3 Support #9

1letter opened this issue Jul 15, 2019 · 12 comments

Comments

@1letter
Copy link

1letter commented Jul 15, 2019

Upgrade for Python3 is needed

@1letter
Copy link
Author

1letter commented Jul 15, 2019

I have add a python3 branch. Please check it.

@aormazabal
Copy link

I have add a python3 branch. Please check it.

Are you interested in merge you're branch to master?
There is some issue in Travis test, that I can't help to resolve. I don't use this kind of pipeline
There is no maintainer in front of this project, it seems...

Maybe some of collaborators could be help to do something:
@bloodbare @mauritsvanrees , @ivanteoh , @djay, @jean ??

@davisagli comented in other Issue post that he doesn't interested.

@djay
Copy link
Member

djay commented Nov 9, 2022

@aormazabal we can help get it merged but first this PR needs to be got working. switching it to use github actions. is that something you can help with? #11

@aormazabal
Copy link

aormazabal commented Nov 9, 2022

@aormazabal we can help get it merged but first this PR needs to be got working. switching it to use github actions. is that something you can help with? #11

Sorry, I'm don't know how it works. I appreciate someone to help. I have this branch in my fork https://github.com/aormazabal/collective.recipe.filestorage/tree/feature/python3 where I made some fixes with the tests. In fact I pull request to this project yesterday

I use Gitlab pipelines in my work. So I'm lost with github...

@aormazabal
Copy link

aormazabal commented Nov 9, 2022

@aormazabal we can help get it merged but first this PR needs to be got working. switching it to use github actions. is that something you can help with? #11

Until we have a solution for that, I've created other pypi project clone with branch python3 https://pypi.org/project/plone.recipe.filestorage/. It would be temporary for my projects and I wanted to prove to upload a project. It's my first time.

I hope not disturb someone with that. I can delete it in any moment. No problem!

@djay
Copy link
Member

djay commented Nov 9, 2022

@aormazabal please don't do that. You can use a branch of your code in buildout easily without having it released on pypi. releasing it on pypi creates confusion and its really bad practice to remove pypi packages so that confusion is there forever. Please take it down now.

@aormazabal
Copy link

aormazabal commented Nov 9, 2022

@aormazabal please don't do that. You can use a branch of your code in buildout easily without having it released on pypi. releasing it on pypi creates confusion and its really bad practice to remove pypi packages so that confusion is there forever. Please take it down now.

OK, I already removed it. So explain how to use my branch in buildout. Is possible to use my branch without place the package in src folder or depelop = in buildout.cfg???

@djay
Copy link
Member

djay commented Nov 9, 2022

@aormazabal We often deploy using develop packages since we need bug fixes before they are merged. We even built a tool called hostout to help make that easy. But we no longer use this since we just use docker with a good .dockerignore to copy our buildout into docker to build.

If you don't want to do it that way then you have two other options

  • run your own simple pypi server. this is not hard to do and I believe many do this
  • put urls in your find-links in buildout to a specific custom built distribution

@davisagli
Copy link
Member

@aormazabal With buildout I would use https://pypi.org/project/mr.developer/ to use an unreleased package. I believe it supports development of buildout recipes too, which is what you need here.

@aormazabal
Copy link

@aormazabal With buildout I would use https://pypi.org/project/mr.developer/ to use an unreleased package. I believe it supports development of buildout recipes too, which is what you need here.

Yes finally I use this option. Thanks

@aormazabal
Copy link

aormazabal commented Nov 14, 2022

@bloodbare @mauritsvanrees , @ivanteoh , @djay, @jean

Hi guys!

I created a new pull request, with python3 support version.
It pass all test with tox in github actions.

The purpose, it will be that next version would be not compatible with python 2 anymore.

It would be possible to someone validate. Who is in front for this kind of decision?

@djay
Copy link
Member

djay commented Nov 14, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants