-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Python3 Support #9
Comments
I have add a python3 branch. Please check it. |
Are you interested in merge you're branch to master? Maybe some of collaborators could be help to do something: @davisagli comented in other Issue post that he doesn't interested. |
@aormazabal we can help get it merged but first this PR needs to be got working. switching it to use github actions. is that something you can help with? #11 |
Sorry, I'm don't know how it works. I appreciate someone to help. I have this branch in my fork https://github.com/aormazabal/collective.recipe.filestorage/tree/feature/python3 where I made some fixes with the tests. In fact I pull request to this project yesterday I use Gitlab pipelines in my work. So I'm lost with github... |
Until we have a solution for that, I've created other pypi project clone with branch python3 https://pypi.org/project/plone.recipe.filestorage/. It would be temporary for my projects and I wanted to prove to upload a project. It's my first time. I hope not disturb someone with that. I can delete it in any moment. No problem! |
@aormazabal please don't do that. You can use a branch of your code in buildout easily without having it released on pypi. releasing it on pypi creates confusion and its really bad practice to remove pypi packages so that confusion is there forever. Please take it down now. |
OK, I already removed it. So explain how to use my branch in buildout. Is possible to use my branch without place the package in src folder or depelop = in buildout.cfg??? |
@aormazabal We often deploy using develop packages since we need bug fixes before they are merged. We even built a tool called hostout to help make that easy. But we no longer use this since we just use docker with a good .dockerignore to copy our buildout into docker to build. If you don't want to do it that way then you have two other options
|
@aormazabal With buildout I would use https://pypi.org/project/mr.developer/ to use an unreleased package. I believe it supports development of buildout recipes too, which is what you need here. |
Yes finally I use this option. Thanks |
@bloodbare @mauritsvanrees , @ivanteoh , @djay, @jean Hi guys! I created a new pull request, with python3 support version. The purpose, it will be that next version would be not compatible with python 2 anymore. It would be possible to someone validate. Who is in front for this kind of decision? |
I'm afraid it needs to support python 2 still. The code is perfectly
capable of still support 2.7.
…On Mon, 14 Nov 2022, 2:34 pm Albert, ***@***.***> wrote:
@bloodbare <https://github.com/bloodbare> @mauritsvanrees
<https://github.com/mauritsvanrees> , @ivanteoh
<https://github.com/ivanteoh> , @djay <https://github.com/djay>, @jean
<https://github.com/jean>
Hi guys!
I realize a new pull request, with python3 support version.
It pass all test with tox in github actions.
The purpose, it will be that next version would be not compatible with
python 2 anymore.
It would be possible to someone validate. Who is in front for this kind of
decision?
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKFZGPRUQQBAUZ5YODQC3WIHTOZANCNFSM4IDWMFDA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Upgrade for Python3 is needed
The text was updated successfully, but these errors were encountered: