Fix IEasyFormWidget marker for GroupForm widgets
#374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrTango
approved these changes
Oct 20, 2022
|
Sorry ;) this is the main part. looping through the group widgets and apply the interface d596b11 ... the rest is maintenance |
|
LGTM |
|
This works and is better than my own attempt in PR #389. I did not notice this PR and related issue when I started working on that. :-/ There are some conflicting files. I will have a look. Maybe I will end up cherry-picking your main commit in a different PR. |
|
I close this in favour of my PR #393 which cherry-picks a few commits from here. Feel free to disagree and reopen of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #370
also updated GHA to mxdev setup