-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CSS/JS #752
Comments
the more-link stuff was added by us a few years for a customer project, but it seems to have been moved to the contentchooser.css in a previous clean up. The question is where the definitions should go. There's a generic cover.css and there's layout_edit.css which is hard coded in the layout view. more links are in list tiles on the compose screen, to stick with the current set up we should create a compose.css. The different resources are annoying to override though: for css you can add higher specific selectors to your theme css, but the resource directory files cannot be overruled with z3c.jbot. When I had the need before i removed the cover resource from the resource registry with upgrade steps and registered my own version, but that becomes a maintenance mess as well. See #756 |
@djowett |
content-chooser.css should be authenticated users only, however it has some rules referencing
more-link-field
. (This is a follow up to #750)Other folk @hvelarde @idgserpro may have more fun refactoring ideas :-)
The text was updated successfully, but these errors were encountered: