Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating refcache per connection breaks "check terms", "check records" per batch #5

Open
kspurgin opened this issue Jan 4, 2021 · 0 comments
Assignees

Comments

@kspurgin
Copy link
Contributor

kspurgin commented Jan 4, 2021

Creating the CollectionSpace::Mapper::DataHandler with the refcache created on the connection object caused a bug when you process a batch with {"check_terms": false} in the batch configuration.

I was unable to reproduce the issue within the collectionspace-mapper and therefore couldn't track it down to fix it there.

This commit changed how the DataHandler gets created for a batch, and fixed the bug.

However it relies on offloading the creation of the refcache to collectionspace-mapper, which we probably don't really want to do in production because collectionspace-mapper doesn't know about Redis, etc...

@kspurgin kspurgin self-assigned this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant