Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosetta-bitcoin and rosetta-ethereum return invalid response on /network/options request #111

Closed
dvc94ch opened this issue Sep 14, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@dvc94ch
Copy link

dvc94ch commented Sep 14, 2022

The rosetta-bitcoin and rosetta-ethereum set the call_methods and balance_exemptions to null. The spec mandates a type of array. It seems like the correct thing to do would be to set the fields to nullable in the spec or return empty arrays in the implementations. Alternatively it would be even better to make the fields optional, but that's a backwards compatibility issue.

@dvc94ch dvc94ch added the bug Something isn't working label Sep 14, 2022
@GeekArthur
Copy link

Thanks for the callout. The rosetta-bitcoin and rosetta-ethereum should update call_methods and balance_exemptions to zero value (empty array) to comply rosetta spec. I created two issues for them accordingly:

I will close this issue and the issue tracking and fix will be moved to the specific rosetta implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants