Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Unreadable status bar if dark mode is enabled #449

Open
Boehrsi opened this issue Mar 16, 2020 · 1 comment · Fixed by #511
Open

Unreadable status bar if dark mode is enabled #449

Boehrsi opened this issue Mar 16, 2020 · 1 comment · Fixed by #511
Labels
bug Something isn't working iOS iOS platform specific issues only

Comments

@Boehrsi
Copy link
Collaborator

Boehrsi commented Mar 16, 2020 •
edited
Loading

Describe the bug

The status bar is unreadable if dark mode is enabled. This happens due to the black background color and the black text color.

Additional context

This happens only on iOS.
@Boehrsi Boehrsi added bug Something isn't working iOS iOS platform specific issues only labels Mar 16, 2020
@phranck phranck self-assigned this Mar 20, 2020
phranck pushed a commit that referenced this issue Apr 3, 2020
OT-717: Unreadable Status Bar
f691c26 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Cleans up code
phranck pushed a commit that referenced this issue Apr 3, 2020
OT-717: Unreadable Status Bar
3ace6d6 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Cleans up code
phranck pushed a commit that referenced this issue Apr 3, 2020
OT-717: Unreadable Status Bar
e0317ff 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Cleans up code
phranck pushed a commit that referenced this issue Apr 3, 2020
OT-717: Unreadable Status Bar
0f89af0 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Cleans up code

ADDITIONAL NOTES
* Changes `activeColor` of all used `Switch.adaptive` widgets to `CustomTheme.of(context).accent` color, because on iOS they had the default green color.
phranck pushed a commit that referenced this issue Apr 3, 2020
OT-717: Unreadable Status Bar
4702368 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Cleans up code

ADDITIONAL NOTES
* Changes `activeColor` of all used `Switch.adaptive` widgets to `CustomTheme.of(context).accent` color, because on iOS they had the default green color.
* Adds `Preference` class with just two static convenience methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for better readability
phranck pushed a commit that referenced this issue Apr 3, 2020
OT-717: Unreadable Status Bar
5d48d17 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Cleans up code

ADDITIONAL NOTES
* Changes `activeColor` of all used `Switch.adaptive` widgets to `CustomTheme.of(context).accent` color, because on iOS they had the default green color.
* Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
phranck pushed a commit that referenced this issue Apr 3, 2020
OT-717: Unreadable Status Bar
0755c2b 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Cleans up code

ADDITIONAL NOTES
* Changes `activeColor` of all used `Switch.adaptive` widgets to `CustomTheme.of(context).accent` color, because on iOS they had the default green color.
* Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
* Adds static getter/setter on `Preference` class for easier handling of preference values (NOTE: Should be discussed if we adopt this system overall)
phranck pushed a commit that referenced this issue Apr 3, 2020
OT-717: Unreadable Status Bar
478ea80 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Cleans up code

ADDITIONAL NOTES
* Changes `activeColor` of all used `Switch.adaptive` widgets to `CustomTheme.of(context).accent` color, because on iOS they had the default green color.
* Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
* Adds static getter/setter on `Preference` class for easier handling of preference values (NOTE: Should be discussed if we adopt this system overall)
  So instead of calling:
  ```
   setPreference(preferenceAppThemeKey, ThemeKey.light.toString());
  ```
  we can call:
  ```
  Preference.themeKeyString = ThemeKey.light.toString();
  ```
phranck pushed a commit that referenced this issue Apr 3, 2020
OT-717: Unreadable Status Bar
63421d6 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Cleans up code

ADDITIONAL NOTES
* Adds `activeColor` setting to all used `Switch.adaptive` widgets with the value of `CustomTheme.of(context).accent`, because on iOS they had the default green color which doesn't fit our application color theme.
* Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
* Adds static getter/setter on `Preference` class for easier handling of preference values (NOTE: Should be discussed if we adopt this system overall)
  So instead of calling:
  ```
   setPreference(preferenceAppThemeKey, ThemeKey.light.toString());
  ```
  we can call:
  ```
  Preference.themeKeyString = ThemeKey.light.toString();
  ```
phranck pushed a commit that referenced this issue Apr 4, 2020
OT-717: Unreadable Status Bar
d0f60c2 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Cleans up code

ADDITIONAL NOTES
* Adds `activeColor` setting to all used `Switch.adaptive` widgets with the value of `CustomTheme.of(context).accent`, because on iOS they had the default green color which doesn't fit our application color theme.
* Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
* Adds static getter/setter on `Preference` class for easier handling of preference values (NOTE: Should be discussed if we adopt this system overall)
  So instead of calling:
  ```
   setPreference(preferenceAppThemeKey, ThemeKey.light.toString());
  ```
  we can call:
  ```
  Preference.themeKeyString = ThemeKey.light.toString();
  ```
phranck pushed a commit that referenced this issue Apr 4, 2020
OT-717: Unreadable Status Bar
1769858 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Cleans up code

ADDITIONAL NOTES
* Adds `activeColor` setting to all used `Switch.adaptive` widgets with the value of `CustomTheme.of(context).accent`, because on iOS they had the default green color which doesn't fit our application color theme.
* Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
* Adds static getter/setter on `Preference` class for easier handling of preference values (NOTE: Should be discussed if we adopt this system overall)
  So instead of calling:
  ```
   setPreference(preferenceAppThemeKey, ThemeKey.light.toString());
  ```
  we can call:
  ```
  Preference.themeKey = ThemeKey.light.toString();
  ```
phranck pushed a commit that referenced this issue Apr 4, 2020
OT-717: Unreadable Status Bar
5aba209 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Cleans up code

ADDITIONAL NOTES
* Adds `activeColor` setting to all used `Switch.adaptive` widgets with the value of `CustomTheme.of(context).accent`, because on iOS they had the default green color which doesn't fit our application color theme.
* Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
* Adds static getter/setter on `Preference` class for easier handling of preference values and better readability (NOTE: Should be discussed if we adopt this system overall)
  So instead of calling:
  ```
   setPreference(preferenceAppThemeKey, ThemeKey.light.toString());
  ```
  we can call:
  ```
  Preference.themeKey = ThemeKey.light.toString();
  ```
phranck pushed a commit that referenced this issue Apr 6, 2020
OT-717: Unreadable Status Bar
2af2364 
Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Adds new assets for all three theme states: Light, Dark, System
* Cleans up code

ADDITIONAL NOTES
* Adds `activeColor` setting to all used `Switch.adaptive` widgets with the value of `CustomTheme.of(context).accent`, because on iOS they had the default green color which doesn't fit our application color theme.
* Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
* Adds static getter/setter on `Preference` class for easier handling of preference values and better readability (NOTE: Should be discussed if we adopt this system overall)
  So instead of calling:
  ```
   setPreference(preferenceAppThemeKey, ThemeKey.light.toString());
  ```
  we can call:
  ```
  Preference.themeKey = ThemeKey.light.toString();
  ```
@phranck phranck mentioned this issue Apr 6, 2020
Merged
Boehrsi added a commit that referenced this issue Apr 8, 2020
@phranck @Boehrsi
OT-717: Unreadable Status Bar (#511)
cc9e6f7 
* OT-717: Unreadable Status Bar

Fixes #449

BUGFIX
* Fixes a bug that happens on switching between Light and Dark mode, which results in an unreadable system status bar

ADDITIONS & CHANGES
* Adds a new `ThemeKey` enum value `system`
* Changes setting for Light/Dark mode in user profile by removing the switch
* Adds a new screen for switching application appearance to `Light`/`Dark` or `System`
* Refactors all `ThemeKey` enum values from UPPERCASE to lowercase
* Adds `vibrateLight` method for haptic feedback when user changes appearance
* Adds new assets for all three theme states: Light, Dark, System
* Cleans up code

ADDITIONAL NOTES
* Adds `activeColor` setting to all used `Switch.adaptive` widgets with the value of `CustomTheme.of(context).accent`, because on iOS they had the default green color which doesn't fit our application color theme.
* Adds `Preference` class with just two static methods `set({@required value, @required String forKey})` and `value({@required String forKey})` for convenience and better readability
* Adds static getter/setter on `Preference` class for easier handling of preference values and better readability (NOTE: Should be discussed if we adopt this system overall)
  So instead of calling:
  ```
   setPreference(preferenceAppThemeKey, ThemeKey.light.toString());
  ```
  we can call:
  ```
  Preference.themeKey = ThemeKey.light.toString();
  ```

* * Fixes broken changes after Merge commit with develop

* Adds missing line break after last line of code
* Fixes bug on using describeEnum(..)
* Updates assets to new versions
* Adapts corner radius at image border according Cornelius' request
* adapts UI according to Cornelius' request
* fixes Image height
* removes code regarding convenience class 'Preference'

* Review changes

Co-authored-by: Boehrsi <[email protected]>
@Boehrsi Boehrsi reopened this Apr 23, 2020
@Boehrsi
Copy link
Collaborator Author

Boehrsi commented Apr 23, 2020

Implemented within the app, but we have to wait for the deployment of flutter/flutter#53034

A new Flutter version is planned for next week, so hopefully the next beta release will contain this fix.

@phranck phranck removed their assignment Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working iOS iOS platform specific issues only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OT-717: Unreadable Status Bar coi-dev/ox-coi
2 participants
@phranck @Boehrsi