You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In addition to adding test coverage for the NewHelmValuesGenerator implementation (and it's associated methods), there may be several ways to improve its implementation, including:
While working on #5 , I bumped up against the use of CUE to build the Helm values.
Comment from the code:
We need to merge the values generated by this function with the user-specified extra helm values.
CUE does not easily handle merging values with multiple levels of precedence, since it sees different concrete values for the same path as a conflict. It supports disjunctions with defaults, but that would only work for a 2-level merge.
For now we can start with the higher precedence user values, then merge in the defaults to paths that do not exist.
TODO: Revisit the use of CUE here, consider reworking to use native Go types with a merge function.
In addition to adding test coverage for the NewHelmValuesGenerator implementation (and it's associated methods), there may be several ways to improve its implementation, including:
The text was updated successfully, but these errors were encountered: