Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Convert to" in i18n.messages.ui.popover missing #2786

Open
Sozialarchiv opened this issue Jul 18, 2024 · 5 comments · May be fixed by #2794
Open

"Convert to" in i18n.messages.ui.popover missing #2786

Sozialarchiv opened this issue Jul 18, 2024 · 5 comments · May be fixed by #2794
Labels
good first issue issue for docs

Comments

@Sozialarchiv
Copy link
Contributor

Sozialarchiv commented Jul 18, 2024 •
edited
Loading

In the i18n example "Convert to" is missing in i18n.messages.ui.popover. It is only mentioned in the toolbar.

https://github.com/codex-team/editor.js/blob/next/example/example-i18n.html#L202

And thanks a lot for this great editor!
@ishon19
Copy link

ishon19 commented Jul 20, 2024

Hey @neSpecc, I'd like to work on this issue! 👋

@Sozialarchiv
Copy link
Contributor Author

There is another missing:

i18n.messages.blockTunes.delete.Click to delete

@lucklyTime
Copy link

I saw it in this place haha
https://github.com/codex-team/editor.js/blob/next/src/components/i18n/locales/en/messages.json

@ishon19 ishon19 linked a pull request Jul 24, 2024 that will close this issue
Open
@blaqdog
Copy link

blaqdog commented Sep 28, 2024 •
edited
Loading

In editorjs 2.30.5 this works:
For tunes block:

messages: {
        ui: {
            "blockTunes": {...},
            "inlineToolbar": {...},
            "toolbar": {...},
            "popover": {
                "Filter": "Фильтр",
                "Nothing found": "Не найдено",
                "Convert to": "Конвертировать в"
            }
        },
...
}

For text selection:

messages: {
	ui: {...},
	toolNames: {...},
	tools: {
		...
		"convertTo": {
			"Convert to": "Конвертировать в"
		},
		...
	},
}

@neSpecc
Copy link
Member

neSpecc commented Nov 18, 2024

Related: #2839 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue issue for docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(docs): Update example-i18n.html ishon19/editor.js
5 participants
@neSpecc @ishon19 @blaqdog @Sozialarchiv @lucklyTime