From 411a8ea0aba208b30f1cd9b1e8e3f8a44156481a Mon Sep 17 00:00:00 2001
From: Tim Fischbach <tfischbach@codevise.de>
Date: Tue, 29 Aug 2023 11:43:44 +0200
Subject: [PATCH] Use width instead position in content elements

REDMINE-20384
---
 .../src/contentElements/counter/Counter.js    |  7 ++++---
 .../src/contentElements/counter/stories.js    |  5 +++--
 .../src/contentElements/heading/Heading.js    |  7 ++++---
 .../imageGallery/ImageGallery.js              | 15 +++++++++++----
 .../inlineImage/InlineImage.js                | 19 +++++++++++++------
 .../src/contentElements/vrImage/VrImage.js    |  7 ++++---
 6 files changed, 39 insertions(+), 21 deletions(-)

diff --git a/entry_types/scrolled/package/src/contentElements/counter/Counter.js b/entry_types/scrolled/package/src/contentElements/counter/Counter.js
index e11b2ed6a..11d6c41f6 100644
--- a/entry_types/scrolled/package/src/contentElements/counter/Counter.js
+++ b/entry_types/scrolled/package/src/contentElements/counter/Counter.js
@@ -8,12 +8,13 @@ import {
   useContentElementLifecycle,
   useI18n,
   useLocale,
-  paletteColor
+  paletteColor,
+  contentElementWidths
 } from 'pageflow-scrolled/frontend';
 
 import styles from './Counter.module.css';
 
-export function Counter({configuration, contentElementId, sectionProps}) {
+export function Counter({configuration, contentElementId, contentElementWidth, sectionProps}) {
   const updateConfiguration = useContentElementConfigurationUpdate();
   const locale = useLocale();
   const {t} = useI18n({locale: 'ui'});
@@ -100,7 +101,7 @@ export function Counter({configuration, contentElementId, sectionProps}) {
 
   return (
     <div className={classNames(
-      {[styles.center]: configuration.position === 'wide' || configuration.position === 'full'}
+      {[styles.center]: contentElementWidth > contentElementWidths.md}
     )}>
       <div className={classNames(
         styles.wrapper,
diff --git a/entry_types/scrolled/package/src/contentElements/counter/stories.js b/entry_types/scrolled/package/src/contentElements/counter/stories.js
index 4e2123516..96a26bf63 100644
--- a/entry_types/scrolled/package/src/contentElements/counter/stories.js
+++ b/entry_types/scrolled/package/src/contentElements/counter/stories.js
@@ -1,5 +1,6 @@
 import '../frontend';
 import {storiesOfContentElement} from 'pageflow-scrolled/spec/support/stories';
+import {contentElementWidths} from 'pageflow-scrolled/frontend';
 
 storiesOfContentElement(module, {
   typeName: 'counter',
@@ -39,9 +40,9 @@ storiesOfContentElement(module, {
       }
     },
     {
-      name: 'Position Wide',
+      name: 'XL Width',
       configuration: {
-        position: 'wide'
+        width: contentElementWidths.xl
       }
     },
     {
diff --git a/entry_types/scrolled/package/src/contentElements/heading/Heading.js b/entry_types/scrolled/package/src/contentElements/heading/Heading.js
index 9243349a3..bf8ac9673 100644
--- a/entry_types/scrolled/package/src/contentElements/heading/Heading.js
+++ b/entry_types/scrolled/package/src/contentElements/heading/Heading.js
@@ -6,12 +6,13 @@ import {
   EditableInlineText,
   useContentElementConfigurationUpdate,
   useDarkBackground,
-  useI18n
+  useI18n,
+  contentElementWidths
 } from 'pageflow-scrolled/frontend';
 
 import styles from './Heading.module.css';
 
-export function Heading({configuration, sectionProps}) {
+export function Heading({configuration, sectionProps, contentElementWidth}) {
   const level = configuration.level || sectionProps.sectionIndex;
   const firstSectionInEntry = level === 0;
   const updateConfiguration = useContentElementConfigurationUpdate();
@@ -31,7 +32,7 @@ export function Heading({configuration, sectionProps}) {
                                darkBackground ? styles.light : styles.dark,
                                {[styles.forcePaddingTop]: forcePaddingTop},
                                {[styles[sectionProps.layout]]:
-                                 configuration.position === 'wide' ||
+                                 contentElementWidth > contentElementWidths.md ||
                                  sectionProps.layout === 'centerRagged'},
                                {[withShadowClassName]: !sectionProps.invert})}>
       <Text scaleCategory={getScaleCategory(configuration, firstSectionInEntry)}
diff --git a/entry_types/scrolled/package/src/contentElements/imageGallery/ImageGallery.js b/entry_types/scrolled/package/src/contentElements/imageGallery/ImageGallery.js
index 1526cf384..900b2533a 100644
--- a/entry_types/scrolled/package/src/contentElements/imageGallery/ImageGallery.js
+++ b/entry_types/scrolled/package/src/contentElements/imageGallery/ImageGallery.js
@@ -11,7 +11,9 @@ import {
   FullscreenViewer,
   Image,
   ToggleFullscreenCornerButton,
-  usePhonePlatform
+  usePhonePlatform,
+  contentElementWidths,
+  contentElementWidthName as widthName,
 } from 'pageflow-scrolled/frontend';
 
 import {ScrollButton} from './ScrollButton';
@@ -19,7 +21,7 @@ import {useIntersectionObserver} from './useIntersectionObserver'
 
 import styles from './ImageGallery.module.css';
 
-export function ImageGallery({configuration, contentElementId, customMargin}) {
+export function ImageGallery({configuration, contentElementId, contentElementWidth, customMargin}) {
   const [visibleIndex, setVisibleIndex] = useState(-1);
   const isPhonePlatform = usePhonePlatform();
 
@@ -29,9 +31,10 @@ export function ImageGallery({configuration, contentElementId, customMargin}) {
       renderChildren={({enterFullscreen, isFullscreen}) =>
         <Scroller customMargin={customMargin}
                   configuration={configuration}
+                  contentElementWidth={contentElementWidth}
                   controlled={isFullscreen}
                   displayFullscreenToggle={!isPhonePlatform &&
-                                           configuration.position !== 'full' &&
+                                           contentElementWidth !== contentElementWidths.full &&
                                            configuration.enableFullscreenOnDesktop}
                   visibleIndex={visibleIndex}
                   setVisibleIndex={setVisibleIndex}
@@ -40,6 +43,7 @@ export function ImageGallery({configuration, contentElementId, customMargin}) {
       renderFullscreenChildren={({exitFullscreen}) => {
         return (
           <Scroller configuration={configuration}
+                    contentElementWidth={contentElementWidth}
                     visibleIndex={visibleIndex}
                     setVisibleIndex={setVisibleIndex}
                     displayFullscreenToggle={false}
@@ -57,6 +61,7 @@ function Scroller({
   onFullscreenEnter, onFullscreenExit,
   onBump,
   configuration,
+  contentElementWidth,
   controlled
 }) {
   const lastVisibleIndex = useRef(null);
@@ -132,7 +137,9 @@ function Scroller({
 
   return (
     <div className={classNames(styles.wrapper,
-                               styles[configuration.position],
+                               {[styles.wide]:
+                                 contentElementWidth === contentElementWidths.lg ||
+                                 contentElementWidth === contentElementWidths.xl},
                                {[styles.customMargin]: customMargin})}>
       <div className={styles.leftButton}>
         <ScrollButton direction="left"
diff --git a/entry_types/scrolled/package/src/contentElements/inlineImage/InlineImage.js b/entry_types/scrolled/package/src/contentElements/inlineImage/InlineImage.js
index b4e6d46ae..b3e33864a 100644
--- a/entry_types/scrolled/package/src/contentElements/inlineImage/InlineImage.js
+++ b/entry_types/scrolled/package/src/contentElements/inlineImage/InlineImage.js
@@ -5,13 +5,14 @@ import {
   Image,
   ContentElementFigure,
   FitViewport,
+  contentElementWidths,
   useContentElementLifecycle,
   useFile,
   usePortraitOrientation,
   ExpandableImage
 } from 'pageflow-scrolled/frontend';
 
-export function InlineImage({contentElementId, configuration}) {
+export function InlineImage({contentElementId, contentElementWidth, configuration}) {
   const imageFile = useFile({
     collectionName: 'imageFiles', permaId: configuration.id
   });
@@ -28,6 +29,7 @@ export function InlineImage({contentElementId, configuration}) {
       <OrientationAwareInlineImage landscapeImageFile={imageFile}
                                    portraitImageFile={portraitImageFile}
                                    contentElementId={contentElementId}
+                                   contentElementWidth={contentElementWidth}
                                    configuration={configuration} />
     );
   }
@@ -35,13 +37,15 @@ export function InlineImage({contentElementId, configuration}) {
     return (
       <ImageWithCaption imageFile={imageFile}
                         contentElementId={contentElementId}
+                        contentElementWidth={contentElementWidth}
                         configuration={configuration} />
     )
   }
 }
 
 function OrientationAwareInlineImage({landscapeImageFile, portraitImageFile,
-                                      contentElementId, configuration}) {
+                                      contentElementId, contentElementWidth,
+                                      configuration}) {
   const portraitOrientation = usePortraitOrientation();
   const imageFile = portraitOrientation && portraitImageFile ?
                     portraitImageFile : landscapeImageFile;
@@ -49,14 +53,16 @@ function OrientationAwareInlineImage({landscapeImageFile, portraitImageFile,
   return (
     <ImageWithCaption imageFile={imageFile}
                       contentElementId={contentElementId}
+                      contentElementWidth={contentElementWidth}
                       configuration={configuration} />
   );
 }
 
-function ImageWithCaption({imageFile, contentElementId, configuration}) {
+function ImageWithCaption({imageFile, contentElementId, contentElementWidth, configuration}) {
   const {shouldLoad} = useContentElementLifecycle();
-  const {enableFullscreen, position} = configuration;
-  const supportFullscreen = enableFullscreen && position !== "full";
+  const {enableFullscreen} = configuration;
+  const supportFullscreen = enableFullscreen &&
+                            contentElementWidth < contentElementWidths.full;
 
   return (
     <FitViewport file={imageFile}
@@ -71,7 +77,8 @@ function ImageWithCaption({imageFile, contentElementId, configuration}) {
               <Image imageFile={imageFile}
                      load={shouldLoad}
                      structuredData={true}
-                     variant={configuration.position === 'full' ? 'large' : 'medium'}
+                     variant={contentElementWidth === contentElementWidths.full ?
+                              'large' : 'medium'}
                      preferSvg={true} />
             </ExpandableImage>
           </FitViewport.Content>
diff --git a/entry_types/scrolled/package/src/contentElements/vrImage/VrImage.js b/entry_types/scrolled/package/src/contentElements/vrImage/VrImage.js
index 6b8de7b63..d24f8208d 100644
--- a/entry_types/scrolled/package/src/contentElements/vrImage/VrImage.js
+++ b/entry_types/scrolled/package/src/contentElements/vrImage/VrImage.js
@@ -2,16 +2,17 @@ import React, {useRef, useState} from 'react';
 import {useAutoCruising} from './useAutoCruising';
 
 import {
+  contentElementWidths,
   useContentElementEditorState,
   useContentElementLifecycle,
   useFile,
   ContentElementBox,
   ContentElementFigure,
   Panorama,
-  FitViewport
+  FitViewport,
 } from 'pageflow-scrolled/frontend';
 
-export function VrImage({configuration}) {
+export function VrImage({configuration, contentElementWidth}) {
   const {shouldLoad} = useContentElementLifecycle();
   const {isEditable, isSelected} = useContentElementEditorState();
 
@@ -20,7 +21,7 @@ export function VrImage({configuration}) {
   return (
     <div style={{pointerEvents: isEditable && !isSelected ? 'none' : undefined}}>
       <FitViewport
-        aspectRatio={configuration.position === 'full' ? 0.5 : 0.75}>
+        aspectRatio={contentElementWidth === contentElementWidths.full ? 0.5 : 0.75}>
         <ContentElementBox>
           <ContentElementFigure configuration={configuration}>
             <FitViewport.Content>