Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor misspellings in authentication forms. #4

Open
dwhite96 opened this issue Oct 2, 2014 · 5 comments
Open

Minor misspellings in authentication forms. #4

dwhite96 opened this issue Oct 2, 2014 · 5 comments

Comments

@dwhite96
Copy link
Contributor

dwhite96 commented Oct 2, 2014

There is a minor misspelling in sessions_new.erb; line 6 says, "Ut oh!" and also users_new.erb line 6.

In index.erb line 10 says, 'It doesn't "looked" like you're signed in.'

@jcdavison
Copy link
Contributor

Hi David,

Not that I am asking you to do our 'bug fixing' cause I can certainly do it, but are you familiar with how to fork, edit, commit and then issue a pull request with said code changes? This is a solid bug fix to practice those behaviors on.

Just a thought, let me know please if you aren't up for it and I will make the changes.

@dwhite96
Copy link
Contributor Author

dwhite96 commented Oct 2, 2014

Sure, I can do that. I was wondering if I should just go ahead and fix it myself and do a pull request.

@jcdavison
Copy link
Contributor

It would be cool, but do you already know how to do what I've described above? If you do, don't worry, I will make the code fix myself.

@dwhite96
Copy link
Contributor Author

dwhite96 commented Oct 2, 2014

I haven't done a pull request yet, but would like to for practice. I'm giving it a try right now.

@jcdavison
Copy link
Contributor

Cool, this is great practice on a topic that can be a little difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants