From 8190cb0bb523ce28b531804330a6c97ee596e40e Mon Sep 17 00:00:00 2001 From: schneems Date: Sat, 28 Oct 2023 08:36:59 -0500 Subject: [PATCH 1/2] Update private repo methods Use the "newer" style of declaring private and make update_repo_info public --- app/models/repo.rb | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/app/models/repo.rb b/app/models/repo.rb index 034359c0..2adcc9ba 100644 --- a/app/models/repo.rb +++ b/app/models/repo.rb @@ -223,18 +223,16 @@ def self.find_by_full_name(full_name) Repo.find_by!(full_name: full_name) end - private - def update_repo_info! UpdateRepoInfoJob.perform_later(self) end - def downcase_name + private def downcase_name self.name.downcase! self.user_name.downcase! end - def set_full_name! + private def set_full_name! if self.full_name && user_name.blank? self.user_name, self.name = self.full_name.split("/") else @@ -242,12 +240,12 @@ def set_full_name! end end - def strip_whitespaces + private def strip_whitespaces self.name.strip! self.user_name.strip! end - def github_url_exists + private def github_url_exists if issues_fetcher.error? errors.add( :expiration_date, From 243f892ac0902ec14090198ff61680aedea1eb87 Mon Sep 17 00:00:00 2001 From: schneems Date: Sat, 28 Oct 2023 08:45:28 -0500 Subject: [PATCH 2/2] We need yard in prod to parse docs --- Gemfile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index fe18e0ff..d3fd860e 100644 --- a/Gemfile +++ b/Gemfile @@ -107,12 +107,14 @@ gem 'aws-sdk-s3' gem 'rake' gem 'rrrretry' +# Parse Ruby documentation +gem 'yard', '~> 0.9.28' + group :development do gem 'foreman' gem 'listen' gem 'memory_profiler' gem 'web-console' - gem 'yard', '~> 0.9.28' end group :test do