From 3face80c2faa25eddbcbfc997aa9ab4af8a8ea4f Mon Sep 17 00:00:00 2001 From: Radovan Bast Date: Tue, 12 Mar 2024 19:31:00 +0100 Subject: [PATCH] add placeholder for a 3rd exercise: code review; closes #278 --- content/code-review.md | 12 ++++++++++++ content/forking-workflow.md | 5 +++++ content/index.md | 1 + content/same-repository.md | 5 +++++ 4 files changed, 23 insertions(+) create mode 100644 content/code-review.md diff --git a/content/code-review.md b/content/code-review.md new file mode 100644 index 0000000..f49e198 --- /dev/null +++ b/content/code-review.md @@ -0,0 +1,12 @@ +# Practicing code review + +Placeholder for an episode on code review. + + +## Exercise + +We are working on creating an exercise for code review: +- suggest a change +- review a change +- reviewer asks for an improvement +- submitter improves the pull request without having to close and open a new one diff --git a/content/forking-workflow.md b/content/forking-workflow.md index f58c8c7..099d1eb 100644 --- a/content/forking-workflow.md +++ b/content/forking-workflow.md @@ -81,6 +81,11 @@ Please step out of the repository and check that you fork the **forking**-workfl ``` +## Exercise + +We are working on combining the steps into one exercise. + + ## Exercise preparation ``````{prereq} Exercise preparation diff --git a/content/index.md b/content/index.md index ed50c49..486b0c6 100644 --- a/content/index.md +++ b/content/index.md @@ -49,6 +49,7 @@ concepts.md same-repository.md forking-workflow.md contributing.md +code-review.md ``` ```{toctree} diff --git a/content/same-repository.md b/content/same-repository.md index ca16929..b5323dc 100644 --- a/content/same-repository.md +++ b/content/same-repository.md @@ -48,6 +48,11 @@ Real life examples: - [https://github.com/ropensci/plotly](https://github.com/ropensci/plotly) +## Exercise + +We are working on combining the steps into one exercise. + + ## Exercise preparation In this exercise we will practice collaborative centralized workflow in